Skip to content

gh-135543: emit sys.remote_exec audit event when sys.remote_exec has been called #135544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Jun 15, 2025

Zheaoli added 2 commits June 16, 2025 02:31
…c has been called

Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli added 2 commits June 16, 2025 03:09
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli and others added 7 commits June 17, 2025 03:06
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
…e-135543.6b0HOF.rst

Co-authored-by: Victor Stinner <vstinner@python.org>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 16, 2025

@vstinner @sobolevn @pablogsal I have updated the test. PTAL when you got time

Zheaoli added 3 commits June 17, 2025 22:44
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 17, 2025

@vstinner I have fix the review idea. PTAL when you got time. BTW https://github.com/python/cpython/actions/runs/15710806342/job/44268135397?pr=135544 seems unrelated failed. Would you mind rerunning it for me?

@Zheaoli Zheaoli requested a review from vstinner June 17, 2025 15:21
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I like the updated code. Another review.

Co-authored-by: Victor Stinner <vstinner@python.org>
Zheaoli and others added 3 commits June 17, 2025 23:40
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli requested a review from vstinner June 17, 2025 15:41
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 17, 2025

@vstinner PTAL when you got time (lol

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal: what do you think?

Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 18, 2025

@vstinner sorry about this, I update a little bit of code. PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new audit event for sys.remote_exec()
4 participants