gh-73487: Convert _decimal to use Argument Clinic (part 2) #137637
+3,815
−735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a025a2d to
d0b03ff
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a4862f9 to
108497e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@skirpichev This PR is +7000/-2000, it's too big. Do you have any suggestions to split it up into parts? A |
|
How about the first commit? |
|
Same here. If you want me to review your PR, please split it into smaller PRs. |
6c8f61f to
1b7845e
Compare
|
Ok, I left only first commit. Is this still too much? |
|
I would prefer a PR which would be 1/3 or 1/4 of that. |
This comment was marked as outdated.
This comment was marked as outdated.
|
I would prefer a single PR containing all changes of the same kind than 10 different PRs. Different kinds of changes can be presented in different PRs. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Ok, I'll redo this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.