-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
gevent: Use a TypeVarTuple
in gevent.baseserver.BaseServer
#11138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gevent: Use a TypeVarTuple
in gevent.baseserver.BaseServer
#11138
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We have removed support for pytype, so I'll also remove the deferred status |
This comment has been minimized.
This comment has been minimized.
This has a conflict now. |
Not really sure what the new stubtest failure is about, the part it's complaining about hasn't changed. |
This comment has been minimized.
This comment has been minimized.
The stubtest failures look potentially related to the changes to |
That looks to be the case. I think I will add a stubtest ignore for this, with the same justification @donBarbos gave for choosing that default value, the With gevent stubtest knows about this white lie, since their cooperative wrapper around |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Second part of the gevent changes, that cannot be merged yet.
Requires
TypeVarTuple
in a generic class to stop crashing pytype.