Skip to content

gevent: Use a TypeVarTuple in gevent.baseserver.BaseServer #11138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 11, 2025

Conversation

Daverball
Copy link
Contributor

@Daverball Daverball commented Dec 10, 2023

Second part of the gevent changes, that cannot be merged yet.

Requires TypeVarTuple in a generic class to stop crashing pytype.

@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Dec 10, 2023

This comment has been minimized.

This comment has been minimized.

@Avasam
Copy link
Collaborator

Avasam commented Jul 30, 2025

We have removed support for pytype, so I'll also remove the deferred status

@Avasam Avasam removed the status: deferred Issue or PR deferred until some precondition is fixed label Jul 30, 2025

This comment has been minimized.

@Daverball Daverball marked this pull request as ready for review July 30, 2025 20:27
@srittau
Copy link
Collaborator

srittau commented Aug 8, 2025

This has a conflict now.

@Daverball
Copy link
Contributor Author

Not really sure what the new stubtest failure is about, the part it's complaining about hasn't changed.

This comment has been minimized.

@brianschubert
Copy link
Member

The stubtest failures look potentially related to the changes to _socket.socket.__init__ in #14503, cc @donBarbos

@Daverball
Copy link
Contributor Author

The stubtest failures look potentially related to the changes to _socket.socket.__init__ in #14503, cc @donBarbos

That looks to be the case. I think I will add a stubtest ignore for this, with the same justification @donBarbos gave for choosing that default value, the -1 is essentially an implementation detail, the documented default is 0 and only when you pass a fileno without specifying proto can you end up with something different.

With gevent stubtest knows about this white lie, since their cooperative wrapper around _socket.socket is written in pure Python, rather than C, so it knows about the exact default values in the implementation.

Copy link
Contributor

github-actions bot commented Aug 9, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 62e28b2 into python:main Aug 11, 2025
48 checks passed
@Daverball Daverball deleted the gevent-baseserver-typevartuple branch August 11, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants