Fix Sonar Blocker issues #281
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @rashidi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on refining the testing approach for schema generation and addressing potential SonarQube issues. It involves removing an outdated test class and refactoring an existing test to specifically validate the existence of the generated schema file, ensuring that automatically generated files are properly ignored by version control.
Highlights
- Test Class Removal: The DataJdbcSchemaGenerationApplicationTests.java test class has been removed, streamlining the test suite.
- Test Refactoring: The BookRepositoryTests.java file has been refactored to remove an unnecessary findAll() test and introduce a new test changelogExists() to verify the presence of the generated user.yaml file.
- Git Ignore Update: The .gitignore file has been updated to include **/user.yaml, preventing the commit of Liquibase generated schema files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively resolves Sonar Blocker issues by removing test cases that lacked assertions and adding a valid test. The new test in BookRepositoryTests.java correctly verifies the generation of the Liquibase changelog file. A key point for future maintainability is that BookRepositoryTests no longer tests BookRepository. Its sole purpose is now to test the schema generation. I recommend renaming the class and file to something more descriptive, like SchemaGenerationTests, to accurately reflect its responsibility. This will make the test suite easier to understand and navigate.
...jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/book/BookRepositoryTests.java
Show resolved
Hide resolved
|
No description provided.