Skip to content

Fix Sonar Blocker issues #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2025
Merged

Fix Sonar Blocker issues #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4056baf
Fix Sonar blocker issues
rashidi Aug 30, 2025
fa0e1e6
Fix Sonar blocker issues
rashidi Aug 30, 2025
50f6be3
Fix Sonar blocker issues
rashidi Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gradle-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
gradle-build:
name: Build project with Gradle
needs: check-changes
if: ${{ needs.check-changes.outputs.build-changes == 'true' }}
if: ${{ needs.check-changes.outputs.build-changes == 'true' || needs.check-changes.outputs.source-changes == 'true' }}
runs-on: ubuntu-latest
outputs:
build-artifacts: ${{ steps.upload-build-artifacts.outputs.artifact-id }}
Expand Down
3 changes: 3 additions & 0 deletions data-jdbc-schema-generation/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,6 @@ out/

### VS Code ###
.vscode/

### Liquibase generated files ###
**/user.yaml
15 changes: 0 additions & 15 deletions ...ion/src/test/java/zin/rashidi/boot/jdbcscgm/DataJdbcSchemaGenerationApplicationTests.java
View file
Open in desktop

This file was deleted.

11 changes: 6 additions & 5 deletions ...c-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/book/BookRepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package zin.rashidi.boot.jdbcscgm.book;

import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.data.jdbc.DataJdbcTest;
Expand All @@ -13,6 +14,8 @@
import java.io.IOException;
import java.util.Set;

import static org.assertj.core.api.Assertions.assertThat;

/**
* @author Rashidi Zin
*/
Expand All @@ -28,12 +31,10 @@ static void generateSchema(@Autowired RelationalMappingContext context) throws I
writer.writeChangeSet(new FileSystemResource("user.yaml"));
}

@Autowired
private BookRepository books;

@Test
void findAll() {
books.findAll();
@DisplayName("Given the user.yaml exists, when changelogExists, then return true")
void changelogExists() {
assertThat(new FileSystemResource("user.yaml").exists()).isTrue();
}

}
Loading