mfd: rp1: Fix device links when modules disabled #7027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Device links are used to keep track of suppliers and consumers of resources, adding some control over the ordering of device probes other than returning -EPROBE_DEFER. The way the RP1 device is created breaks this mechanism in the rare case that the use of modules has been completely disabled, thanks to some opimisations within the device link code. Fix this glitch by giving the corresponding fwnode a pointer to the device, taking the opportunity to remove a pointless check on the validity of the rp1_node pointer. See: raspberrypi#7018 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
|
Merging as low risk. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 5, 2025
kernel: configs: Add EROFS_FS_ZIP_ZSTD See: raspberrypi/linux#7028 kernel: dt: Add eth_max_speed override for CM4, Pi4, and Pi400 See: raspberrypi/linux#7031 kernel: mfd: rp1: Fix device links when modules disabled See: raspberrypi/linux#7027 kernel: Add adxl355 to i2c-sensor See: raspberrypi/linux#6823 kernel: dtoverlays: Switch ssd1306 to use the DRM driver See: raspberrypi/linux#7034 kernel: Added device tree overlays for the rpi-power HAT See: raspberrypi/linux#7036 kernel: fixup! misc: rp1-pio: Request a DMA burst size of 8 See: raspberrypi/linux#7037
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Sep 5, 2025
kernel: configs: Add EROFS_FS_ZIP_ZSTD See: raspberrypi/linux#7028 kernel: dt: Add eth_max_speed override for CM4, Pi4, and Pi400 See: raspberrypi/linux#7031 kernel: mfd: rp1: Fix device links when modules disabled See: raspberrypi/linux#7027 kernel: Add adxl355 to i2c-sensor See: raspberrypi/linux#6823 kernel: dtoverlays: Switch ssd1306 to use the DRM driver See: raspberrypi/linux#7034 kernel: Added device tree overlays for the rpi-power HAT See: raspberrypi/linux#7036 kernel: fixup! misc: rp1-pio: Request a DMA burst size of 8 See: raspberrypi/linux#7037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device links are used to keep track of suppliers and consumers of resources, adding some control over the ordering of device probes other than returning -EPROBE_DEFER. The way the RP1 device is created breaks this mechanism in the rare case that the use of modules has been completely disabled, thanks to some opimisations within the device link code.
Fix this glitch by giving the corresponding fwnode a pointer to the device, taking the opportunity to remove a pointless check on the validity of the rp1_node pointer.
See: #7018