-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added device tree overlays for the rpi-power HAT. #7036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few inline comments, but the main issues that that the automatic checks will flag up is that every overlay needs a rule in the Makefile to build it and an entry in the README file.
target-path = "/"; | ||
__overlay__ { | ||
rpi_power_hat_b: rpi-power-hat-b { | ||
compatible = "Raspberry Pi,rpi-power-hat-b"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct prefix for Raspberry Pi Ltd. is "raspberrypi".
}; | ||
}; | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git prefers all files to end with a newline.
power2-monitor = <&pwr2_monitor>; | ||
|
||
// HAT metadata | ||
hat-name = "rpi-power-hat Bottom"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this is meant to do. If it's for human readability, the compatible string should be enough.
arch/arm/boot/dts/overlays/Makefile
Outdated
@@ -247,6 +247,8 @@ dtbo-$(CONFIG_ARCH_BCM2835) += \ | |||
rpi-fw-uart.dtbo \ | |||
rpi-poe.dtbo \ | |||
rpi-poe-plus.dtbo \ | |||
rpi-power-hat-b-overlay.dtbo \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The make rules transform *-overlay.dts
into *.dtbo
, so drop the -overlay
s here.
492b567
to
d2f1b8f
Compare
If you run |
And the overlay entries in README and Makefile must be in alphabetical order. |
d2f1b8f
to
9d045b3
Compare
Checkpatch is complaining about undocumented DT compatible strings and MAINTAINERS needing updating - is it okay to ignore these warnings? |
Yes, I'll waive those. |
Added 2 overlays for the rpi-power HAT to operate in either TOP or BOTTOM mode. Modified makefile and readme accordingly Signed-off-by: Lucas Hoffmann <lucas.hoffmann@raspberrypi.com>
9d045b3
to
845f06f
Compare
kernel: configs: Add EROFS_FS_ZIP_ZSTD See: raspberrypi/linux#7028 kernel: dt: Add eth_max_speed override for CM4, Pi4, and Pi400 See: raspberrypi/linux#7031 kernel: mfd: rp1: Fix device links when modules disabled See: raspberrypi/linux#7027 kernel: Add adxl355 to i2c-sensor See: raspberrypi/linux#6823 kernel: dtoverlays: Switch ssd1306 to use the DRM driver See: raspberrypi/linux#7034 kernel: Added device tree overlays for the rpi-power HAT See: raspberrypi/linux#7036 kernel: fixup! misc: rp1-pio: Request a DMA burst size of 8 See: raspberrypi/linux#7037
kernel: configs: Add EROFS_FS_ZIP_ZSTD See: raspberrypi/linux#7028 kernel: dt: Add eth_max_speed override for CM4, Pi4, and Pi400 See: raspberrypi/linux#7031 kernel: mfd: rp1: Fix device links when modules disabled See: raspberrypi/linux#7027 kernel: Add adxl355 to i2c-sensor See: raspberrypi/linux#6823 kernel: dtoverlays: Switch ssd1306 to use the DRM driver See: raspberrypi/linux#7034 kernel: Added device tree overlays for the rpi-power HAT See: raspberrypi/linux#7036 kernel: fixup! misc: rp1-pio: Request a DMA burst size of 8 See: raspberrypi/linux#7037
Added 2 device tree overlays for the rpi-control-hat. One for 'bottom' mode and one for 'top' mode.