Selective inspect of instance variables #13555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Make Kernel#inspect ask which instance variables should be dumped by the result of `#instance_variables_to_inspect`. Co-Authored-By: Jean Boussier <byroot@ruby-lang.org>
6ddd72d to
e643b25
Compare
joshuay03
reviewed
Jun 9, 2025
Comment on lines
+19
to
+20
| * `Kernel#inspect` now check for the existence of a `#instance_variables_to_inspect` method | ||
| allowing to control which instance variables are displayed in the `#inspect` string: |
There was a problem hiding this comment.
Suggested change
| * `Kernel#inspect` now check for the existence of a `#instance_variables_to_inspect` method | |
| allowing to control which instance variables are displayed in the `#inspect` string: | |
| * `Kernel#inspect` now checks for the existence of a `#instance_variables_to_inspect` method, | |
| allowing control over which instance variables are displayed in the `#inspect` string: |
| @@ -28,4 +28,34 @@ class << obj | |||
| end | |||
| obj.inspect.should be_kind_of(String) | |||
| end | |||
|
|
|||
| ruby_version_is "3.5" do | |||
| it "calls #instance_variables_to_inspect private method to know which variables to display" do | |||
There was a problem hiding this comment.
Reading this I assumed it had to be a private method, but the implementation tells me it doesn't. What do you think about removing the mention of private here and making the method public in the empty override case (see next suggestion) so both are covered?
Suggested change
| it "calls #instance_variables_to_inspect private method to know which variables to display" do | |
| it "calls #instance_variables_to_inspect method to know which variables to display" do |
There was a problem hiding this comment.
I assumed it had to be a private method,
No method ever have to be private. e.g. method_missing is supposed to be private, but nothing will break if it isn't.
| @password = "hunter2" | ||
| end | ||
| obj.singleton_class.class_eval do | ||
| private def instance_variables_to_inspect = [] |
There was a problem hiding this comment.
Suggested change
| private def instance_variables_to_inspect = [] | |
| def instance_variables_to_inspect = [] |
joshuay03
added a commit
to joshuay03/ruby
that referenced
this pull request
Jun 9, 2025
joshuay03
added a commit
to joshuay03/ruby
that referenced
this pull request
Jun 9, 2025
Merged
Actually it's late here so I've just opened this if you decide to merge them: #13564 |
joshuay03
added a commit
to joshuay03/ruby
that referenced
this pull request
Jun 10, 2025
joshuay03
added a commit
to joshuay03/ruby
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature #21219]
Make Kernel#inspect ask which instance variables should be dumped by the result of
#instance_variables_to_inspect.