Skip to content

Follow-ups to #13555 #13564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Follow-ups to #13555 #13564

merged 1 commit into from
Jun 10, 2025

Conversation

joshuay03
Copy link
Contributor

Addresses #13555 (review)

@joshuay03 joshuay03 mentioned this pull request Jun 9, 2025
Merged
@joshuay03 joshuay03 moved this to In Progress / Pending Review in Open Source Jun 9, 2025
@byroot
Copy link
Member

byroot commented Jun 9, 2025

I'm fine with the NEWS.md change, but not for the spec change. The spec should test that the implementation is OK with calling a private method.

@joshuay03 joshuay03 force-pushed the follow-ups-to-13555 branch from ecb0d03 to c8ce3c5 Compare June 10, 2025 09:13
@joshuay03 joshuay03 force-pushed the follow-ups-to-13555 branch from c8ce3c5 to 6f75184 Compare June 10, 2025 09:13
@joshuay03
Copy link
Contributor Author

I've dropped the spec change 👍🏽

@byroot byroot merged commit a21acae into ruby:master Jun 10, 2025
55 checks passed
@joshuay03 joshuay03 deleted the follow-ups-to-13555 branch June 10, 2025 11:31
@joshuay03 joshuay03 moved this from In Progress / Pending Review to Done in Open Source Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuay03 @byroot