Skip to content

Allow to pass context to pyobjects renderer #68224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3006.x
Choose a base branch
from

Conversation

vvrein
Copy link

@vvrein vvrein commented Jul 31, 2025

What does this PR do?

Allows to pass context to pyobjects renderer

What issues does this PR fix or reference?

Fixes #68223

@vvrein vvrein requested a review from a team as a code owner July 31, 2025 10:25
Copy link

welcome bot commented Jul 31, 2025

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject.pdl@broadcom.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but we need a changelog and some tests for this. Would you mind doing that?

@frebib
Copy link
Contributor

frebib commented Aug 1, 2025

Using mutable default arguments in functions is dangerous: https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments

@twangboy
Copy link
Contributor

twangboy commented Aug 4, 2025

@frebib makes a valid point. The article they referenced demonstrates how to better handle this scenario. The Lint Failures are related to this as well.

@vvrein
Copy link
Author

vvrein commented Aug 5, 2025

@frebib Will update the code with immutable default.
@twangboy I'll need to figure out how to add tests for this, and there might be needed some extra cycles of tests correction as well.
Thank you!

twangboy
twangboy previously approved these changes Aug 7, 2025
@vvrein
Copy link
Author

vvrein commented Aug 8, 2025

@twangboy do I need reformat code as pipeline shows? Also, do I need to rebase changes periodically, or they will be just merged on top, if no conflicts appears?

@twangboy
Copy link
Contributor

Yeah, you need to fix pre-commit/lint failures. I just did that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants