-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Allow to pass context to pyobjects renderer #68224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3006.x
Are you sure you want to change the base?
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but we need a changelog and some tests for this. Would you mind doing that?
Using mutable default arguments in functions is dangerous: https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments |
@frebib makes a valid point. The article they referenced demonstrates how to better handle this scenario. The Lint Failures are related to this as well. |
@twangboy do I need reformat code as pipeline shows? Also, do I need to rebase changes periodically, or they will be just merged on top, if no conflicts appears? |
Yeah, you need to fix pre-commit/lint failures. I just did that |
What does this PR do?
Allows to pass context to pyobjects renderer
What issues does this PR fix or reference?
Fixes #68223