Fix/cli arg parsing and test logic 3007.x #68232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/pytests/unit/loader/test_lazy.py
|
These changes from your #68122 PR will be merged forward to the 3007.x and master branchs. You don't need to create a separate PR. |
|
OK, cool. I'll approve this. |
twangboy
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalize test value to strictly boolean output
These changes are related to async (coroutine) functionality that is not present in 3006.x.
They also seems necessary to resolve issue #68121.
What issues does this PR fix or reference?
Fixes #68121
Previous Behavior
For more details, please refer to the previous PR, #68122.
New Behavior
For more details, please refer to the previous PR, #68122.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes