Skip to content

Conversation

DdangJin
Copy link
Contributor

@DdangJin DdangJin commented Aug 4, 2025

What does this PR do?

This PR for the 3007.x branch applies the same modifications to LoadedCoro as the changes I previously submitted(#68122).

Normalize test value to strictly boolean output

These changes are related to async (coroutine) functionality that is not present in 3006.x.
They also seems necessary to resolve issue #68121.

What issues does this PR fix or reference?

Fixes #68121

Previous Behavior

For more details, please refer to the previous PR, #68122.

New Behavior

For more details, please refer to the previous PR, #68122.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy
Copy link
Contributor

twangboy commented Aug 4, 2025

These changes from your #68122 PR will be merged forward to the 3007.x and master branchs. You don't need to create a separate PR.

@DdangJin
Copy link
Contributor Author

DdangJin commented Aug 6, 2025

@twangboy
There are only sync function code modifications on #68122, and there are no code modifications related to async.
So I wrote it because I thought I needed this PR because of the async fix.

Is there anything I should do?

@twangboy
Copy link
Contributor

twangboy commented Aug 6, 2025

OK, cool. I'll approve this.

@dwoz dwoz self-assigned this Aug 21, 2025
@dwoz dwoz merged commit 551e295 into saltstack:3007.x Aug 27, 2025
1631 of 1647 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants