Skip to content

Conversation

sotagg
Copy link
Contributor

@sotagg sotagg commented Aug 28, 2025

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR removes the unused and misleading steps attribute from the _BaseComposition class. This attribute served no functional purpose since subclasses define their own attributes in __init__() (e.g., Pipeline uses steps while ColumnTransformer uses transformers).

I also updated the docstring to better explain the design pattern.

Any other comments?

Copy link

github-actions bot commented Aug 28, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: bef64ed. Link to the linter CI: here

@sotagg sotagg changed the title Refactor: remove the step attribute from _BaseComposition MNT: remove the step attribute from _BaseComposition Aug 28, 2025
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Can you reword the following to not use "steps" anymore?

@sotagg sotagg changed the title MNT: remove the step attribute from _BaseComposition MNT: remove the steps attribute from _BaseComposition Aug 29, 2025
@sotagg sotagg force-pushed the refactor/remove-unused-attribute branch from 12f3fc7 to bef64ed Compare August 30, 2025 00:59
@sotagg
Copy link
Contributor Author

sotagg commented Aug 30, 2025

@thomasjpfan
Thanks for the feedback! I've updated the comments. Please let me know if this looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants