-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DomCrawler][BrowserKit] Unable to submit form with button value #58509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, thanks for your report! |
Just a quick reminder to make a comment on this. If I don't hear anything I'll close this. |
Please open a PR to update the documentation to document the correct behavior (which is the same behavior since years). |
nicolas-grekas
added a commit
that referenced
this issue
Jun 15, 2025
…atTheCat) This PR was merged into the 6.4 branch. Discussion ---------- [DomCrawler] Allow selecting `button`s by their `value` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #58509 | License | MIT `Crawler::selectButton` can select an `input` by its `value`, which is tested but not documented. However, it cannot select a `button` by its `value`. I don’t think this is intentional, which is why I opened this PR as a bugfix. I also updated `Crawler::selectButton`’s PHPDoc and tests to better reflect what it does. Commits ------- c45ecfa [DomCrawler] Allow selecting `button`s by their `value`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected
7.1
Description
The
submitForm(string $button, ...)
method indicates :However, the
value
attribute doesn't seem to be checked :How to reproduce
Possible Solution
The XPath query behind this doesn't check the
value
attribute of<button>
tags:I can work on a PR if you confirm the issue. Thanks
Additional Context
No response
The text was updated successfully, but these errors were encountered: