Skip to content

fix(typescript-estree): add validation to interface extends #11271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2025
Merged

fix(typescript-estree): add validation to interface extends #11271

merged 5 commits into from
Jun 9, 2025

Conversation

ntdiary
Copy link
Contributor

@ntdiary ntdiary commented Jun 5, 2025 •
edited
Loading

PR Checklist

Overview

The validation logic comes from TypeScript. isPropertyAccessEntityNameExpression and isEntityNameExpression are internal functions from TypeScript, I’ve temporarily placed them above the Converter class, not sure if that’s the good place for them. :)

These are some cases that will throw errors:

// ParenthesizedExpression
interface A extends (typeof fs) { }

// ElementAccessExpression
interface B extends C['D'] { }

// OptionalChain
interface E extends F?.G { }

// multiple extends
interface H extends I extends J { }

// NumericLiteral
interface K extends 2 { }

// nested CallExpression
interface L extends M().N { }

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 5, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 98625ef
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/684689c3cb88bb000821e3da
😎 Deploy Preview https://deploy-preview-11271--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 98625ef.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 3s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 57s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 18s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run-many -t lint ✅ Succeeded 11s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 7s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run generate-configs ✅ Succeeded 9s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-09 07:26:27 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base (d159a21) to head (98625ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 0.00% 29 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11271      +/-   ##
==========================================
- Coverage   90.91%   90.85%   -0.06%     
==========================================
  Files         501      501              
  Lines       50872    50901      +29     
  Branches     8383     8383              
==========================================
  Hits        46248    46248              
- Misses       4609     4638      +29     
  Partials       15       15
Flag Coverage Δ
unittest 90.85% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 30.37% <0.00%> (-0.29%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntdiary ntdiary marked this pull request as ready for review June 5, 2025 12:23
bradzacher
bradzacher previously approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher enabled auto-merge (squash) June 9, 2025 07:14
@bradzacher bradzacher disabled auto-merge June 9, 2025 07:21
@bradzacher bradzacher enabled auto-merge (squash) June 9, 2025 07:21
@bradzacher bradzacher merged commit 685e530 into typescript-eslint:main Jun 9, 2025
61 checks passed
@fisker fisker mentioned this pull request Jun 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Forbid invalid extend in interface
2 participants
@ntdiary @bradzacher