Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of br tags in SATO examples #292

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

leo-barnes
Copy link
Collaborator

@leo-barnes leo-barnes commented Oct 24, 2024

This closes #291.

I think the output looks nicer at least. I also removed a redundant <li> tag and converted the NOTE to a bikeshed NOTE.


Preview | Diff

Copy link
Collaborator

@y-guyon y-guyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced that

is easier to read than

It makes the second "and its PixelInformationProperty" look like it is relative to "as the first input image item" because it is on the same line.
The "same spatial dimensions" is in another line than "as the first input image item" so it does not look like they are linked.
Moreover "and its PixelInformationProperty with bits_per_channel=16" is on a new line below, so it is inconsistent.


Approval for the fixed <li>.

@leo-barnes
Copy link
Collaborator Author

I am not convinced that

...

is easier to read than

...

It makes the second "and its PixelInformationProperty" look like it is relative to "as the first input image item" because it is on the same line. The "same spatial dimensions" is in another line than "as the first input image item" so it does not look like they are linked. Moreover "and its PixelInformationProperty with bits_per_channel=16" is on a new line below, so it is inconsistent.

Yeah, I couldn't really make work in a nice way, but it was the only way I could think of to address @wantehchang's issue.
I can revert the <br> changes (excepting the added newlines in index.bs since I prefer the raw text to look as similar to the rendered text as possible).

@leo-barnes
Copy link
Collaborator Author

Let me try the suggestion from the issue and remove MIAF.

@leo-barnes
Copy link
Collaborator Author

Let me try the suggestion from the issue and remove MIAF.

Ok, that seems to work. @y-guyon, does it look good to you?

Copy link
Collaborator

@y-guyon y-guyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you!

@leo-barnes leo-barnes force-pushed the u/lbarnes/fix_br_in_sato_examples branch from 5e337f5 to 7089fa9 Compare October 25, 2024 12:34
@leo-barnes leo-barnes merged commit 48dc1c6 into master Oct 25, 2024
@leo-barnes leo-barnes deleted the u/lbarnes/fix_br_in_sato_examples branch October 25, 2024 12:35
github-actions bot added a commit that referenced this pull request Oct 25, 2024
SHA: 48dc1c6
Reason: push, by leo-barnes

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of <br> results in bad formatting
2 participants