-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of br tags in SATO examples #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced that
A MIAF image item being a lossily coded image item, and its PixelInformationProperty with bits_per_channel=12.
Another MIAF image item being a lossily or losslessly coded image item with the
same spatial dimensions,
same number of channels,
same chroma subsampling (or lack thereof)
as the first input image item, and its PixelInformationProperty with bits_per_channel=8,
with the following contraints:
is easier to read than
A MIAF image item being a lossily coded image item,
and its PixelInformationProperty with bits_per_channel=12,Another MIAF image item being a lossily or losslessly coded image item with the same spatial dimensions, the same number of channels, and the same chroma subsampling (or lack thereof) as the first input image item,
and its PixelInformationProperty with bits_per_channel=8,
with the following contraints:
It makes the second "and its PixelInformationProperty" look like it is relative to "as the first input image item" because it is on the same line.
The "same spatial dimensions" is in another line than "as the first input image item" so it does not look like they are linked.
Moreover "and its PixelInformationProperty with bits_per_channel=16" is on a new line below, so it is inconsistent.
Approval for the fixed <li>
.
Yeah, I couldn't really make work in a nice way, but it was the only way I could think of to address @wantehchang's issue. |
Let me try the suggestion from the issue and remove MIAF. |
Ok, that seems to work. @y-guyon, does it look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you!
5e337f5
to
7089fa9
Compare
SHA: 48dc1c6 Reason: push, by leo-barnes Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This closes #291.
I think the output looks nicer at least. I also removed a redundant
<li>
tag and converted the NOTE to a bikeshed NOTE.Preview | Diff