Skip to content

Moving private includes to sub-directory, #464 #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2017
Merged

Moving private includes to sub-directory, #464 #507

merged 5 commits into from
Aug 20, 2017

Conversation

bengtmartensson
Copy link
Contributor

This PM implements the sub-directories as discussed in the context of #464.

Remove #include "IRremoteInt.h" from a number of files since it
now does not work any more, and since IRremote.h #includes it already.
This resolves #464.
@@ -3,6 +3,7 @@ version=2.4.0
author=shirriff, z3t0
maintainer=z3t0
sentence=Send and receive infrared signals with multiple protocols
paragraph=Send and receive infrared signals with multiple protocols
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paragraph is added to the sentence to create the total description. Not much point in having paragraph if it's just a duplicate of sentence?

@bengtmartensson
Copy link
Contributor Author

Not much point in having paragraph if it's just a duplicate of sentence?

The reason that I added it was that the Arduino IDE (1.8.3) complained. (I started arduino from an xterm, if you start it by double clicking or something, it may happen that these warnings go into nirvana.) If "paragraph" is optional, then the IDE behaves incorrectly.

The best thing would probably be to add a "paragraph" (= several sentences) stating something more non-trivial. Personally, I do not really care.

@z3t0
Copy link
Collaborator

z3t0 commented Aug 18, 2017

That's odd, what about this then as the paragraph:

Arduino-IRremote has built in support for sending and decoding many IR signals.

@bengtmartensson
Copy link
Contributor Author

I just revoked the change to library.properties, in order to keep the 1-1 correspondence to #464. (It was just a ugly warning that I wanted to kill.) After all, the warning does not hamper proper operation.

Still think that it should be fixed, though.

@z3t0
Copy link
Collaborator

z3t0 commented Aug 20, 2017

Still think that it should be fixed, though.

Could you open an issue with the warning output? That way we can explore this while also merging these changes.

@z3t0 z3t0 merged commit 24dd940 into Arduino-IRremote:beta Aug 20, 2017
@bengtmartensson bengtmartensson deleted the beta_subdirs branch July 5, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants