-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Moving private includes to sub-directory, #464 #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove #include "IRremoteInt.h" from a number of files since it now does not work any more, and since IRremote.h #includes it already. This resolves #464.
library.properties
Outdated
@@ -3,6 +3,7 @@ version=2.4.0 | |||
author=shirriff, z3t0 | |||
maintainer=z3t0 | |||
sentence=Send and receive infrared signals with multiple protocols | |||
paragraph=Send and receive infrared signals with multiple protocols |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paragraph is added to the sentence to create the total description. Not much point in having paragraph if it's just a duplicate of sentence?
The reason that I added it was that the Arduino IDE (1.8.3) complained. (I started arduino from an xterm, if you start it by double clicking or something, it may happen that these warnings go into nirvana.) If "paragraph" is optional, then the IDE behaves incorrectly. The best thing would probably be to add a "paragraph" (= several sentences) stating something more non-trivial. Personally, I do not really care. |
That's odd, what about this then as the paragraph: Arduino-IRremote has built in support for sending and decoding many IR signals. |
I just revoked the change to library.properties, in order to keep the 1-1 correspondence to #464. (It was just a ugly warning that I wanted to kill.) After all, the warning does not hamper proper operation. Still think that it should be fixed, though. |
Could you open an issue with the warning output? That way we can explore this while also merging these changes. |
This PM implements the sub-directories as discussed in the context of #464.