Skip to content

Commit 0b1c361

Browse files
petekanevSvetoslavTsenov
authored andcommitted
refactor(console): remove the console module (NativeScript#5338)
* refactor(console): remove the console module Removing the console module implementation eliminates some error-prone formatting logic, and certain platform-specific checks. The implementation was also android-specific. Left a stub Console class implementation as one is necessary to avoid errors with `console` being undefined during the snapshot stage for android. The console module is replaced by a 'console' implementation in the Android Runtime. See android-runtime/PR NativeScript#884 * fix(tests): update console module tests
1 parent 464cdd5 commit 0b1c361

File tree

4 files changed

+34
-404
lines changed

4 files changed

+34
-404
lines changed

apps/app/ui-tests-app/events/console.ts

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,6 @@ export function pageLoaded() {
3434
var str = "text";
3535
var obj = { name: "John", age: 34 };
3636
var button = new buttonModule.Button();
37-
function Foo() {
38-
this.abc = "Hello";
39-
this.circular = this;
40-
}
41-
var foo = new Foo();
4237

4338
console.log(true);
4439
console.log(false);
@@ -49,17 +44,21 @@ export function pageLoaded() {
4944
console.log(str);
5045
console.log(obj);
5146

52-
console.log('number: %i', num);
53-
console.log('string: %s', str);
54-
console.log("%s %f", str, num);
47+
console.log(`number: ${num}`);
48+
console.log(`string: ${str}`);
49+
console.log(`${str} ${num}`);
5550

5651
console.info("info");
5752
console.warn("warn");
5853
console.error("error");
5954

60-
console.assert(false, "%d not equals %d", 0, 1);
55+
console.assert(false, `false == true`);
6156
console.assert(true, "1 equals 1");
6257

58+
console.assert("", "empty string evalutes to 'false'");
59+
60+
console.trace("console.trace() called");
61+
6362
if (app.android) {
6463
console.dir(true);
6564
console.dir(false);
@@ -70,8 +69,10 @@ export function pageLoaded() {
7069
console.dir(str);
7170

7271
console.dir(obj);
73-
console.dir(foo);
74-
console.log("%j", button);
72+
console.log(`${button}`);
73+
74+
console.log(num, str, obj);
75+
console.log([1, 5, 12.5, obj, str, 42]);
7576
}
7677

7778
console.trace();

tns-core-modules/console/Readme.md

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)