refactor(console): remove the console module #5338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the console module implementation eliminates some error-prone formatting logic, and certain platform-specific checks. The implementation was also android-specific. Left a stub Console class implementation as one is necessary to avoid errors with `console` being undefined during the snapshot stage for android. The console module is replaced by a 'console' implementation in the Android Runtime. See android-runtime/PR #884
|
uitests |
vakrilov
approved these changes
Jan 31, 2018
|
test android uitests |
1 similar comment
|
test android uitests |
|
test android#pete/revert-console uitests |
|
test android#pete/revert-console uitests#pete/fix-console-tests |
4 similar comments
|
test android#pete/revert-console uitests#pete/fix-console-tests |
|
test android#pete/revert-console uitests#pete/fix-console-tests |
|
test android#pete/revert-console uitests#pete/fix-console-tests |
|
test android#pete/revert-console uitests#pete/fix-console-tests |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting PR based on the 'master' branch.
Removing the console module implementation eliminates some error-prone formatting logic, and certain platform-specific checks. The implementation was also android-specific. Left a stub Console class
implementation as one is necessary to avoid errors with
consolebeing undefined during the snapshot stage for android.The console module is replaced by a 'console' implementation in the Android Runtime. See android-runtime/PR NativeScript/android#884
Unit test changes PR - NativeScript/functional-tests#9