Set full build on Travis #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💯 |
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
petekanev
added a commit
that referenced
this pull request
Dec 19, 2017
Removing the console module eliminates some error-prone logic, and unnecessary platform-specific checks. The implementation was also android-specific. The console module is replaced by a 'console' implementation in the Android Runtime. See android-runtime/PR #884
petekanev
added a commit
that referenced
this pull request
Jan 8, 2018
Removing the console module implementation eliminates some error-prone formatting logic, and certain platform-specific checks. The implementation was also android-specific. Left a stub Console class implementation as one is necessary to avoid errors with `console` being undefined during the snapshot stage for android. The console module is replaced by a 'console' implementation in the Android Runtime. See android-runtime/PR #884
petekanev
added a commit
that referenced
this pull request
Jan 26, 2018
Removing the console module implementation eliminates some error-prone formatting logic, and certain platform-specific checks. The implementation was also android-specific. Left a stub Console class implementation as one is necessary to avoid errors with `console` being undefined during the snapshot stage for android. The console module is replaced by a 'console' implementation in the Android Runtime. See android-runtime/PR #884
SvetoslavTsenov
pushed a commit
that referenced
this pull request
Feb 4, 2018
* refactor(console): remove the console module Removing the console module implementation eliminates some error-prone formatting logic, and certain platform-specific checks. The implementation was also android-specific. Left a stub Console class implementation as one is necessary to avoid errors with `console` being undefined during the snapshot stage for android. The console module is replaced by a 'console' implementation in the Android Runtime. See android-runtime/PR #884 * fix(tests): update console module tests
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.