Skip to content

Allow Laravel 9, improve Codeception 5 support #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2022
Merged

Allow Laravel 9, improve Codeception 5 support #39

merged 2 commits into from
Feb 17, 2022

Conversation

lapiy
Copy link
Contributor

@lapiy lapiy commented Feb 17, 2022

This small PR adds Laravel 9 and php 8.1 compatibility

@lapiy
Copy link
Contributor Author

lapiy commented Feb 17, 2022

seems this PR is not really ready

@lapiy lapiy closed this Feb 17, 2022
@TavoNiievez
Copy link
Member

laravel-module-tests must also be updated to get the tests OK.
and even if the latter is updated, I can't guarantee that there isn't some incompatible package still blocking us. That's why I approved the changes as is.
The codecept5 branch is still a WIP, so please point your PR to it instead of main.

@lapiy
Copy link
Contributor Author

lapiy commented Feb 17, 2022

ok, got it.

@lapiy lapiy reopened this Feb 17, 2022
@lapiy lapiy changed the base branch from main to codecept5 February 17, 2022 13:20
@TavoNiievez TavoNiievez changed the title Codecept5 Allow Laravel 9, improve Codeception 5 support Feb 17, 2022
@TavoNiievez TavoNiievez merged commit 3ea6acb into Codeception:codecept5 Feb 17, 2022
@Naktibalda Naktibalda mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TavoNiievez TavoNiievez TavoNiievez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lapiy @TavoNiievez