Skip to content

Codeception 5 support #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 20, 2022
Merged

Codeception 5 support #40

merged 5 commits into from
Apr 20, 2022

Conversation

Naktibalda
Copy link
Member

No description provided.

@Naktibalda
Copy link
Member Author

I will try to fix CI

TavoNiievez
TavoNiievez reviewed Apr 19, 2022
View reviewed changes
@Naktibalda
Copy link
Member Author

I noticed 2 issues while testing Laravel 6.

  1. It is incompatible with PHP 8.1
  2. It requires vlucas/phpdotenv v3, but Codeception 5 dropped support for vlucas/phpdotenv v3 and v4.
  During inheritance of ArrayAccess: Uncaught ErrorException: Return type of Illuminate\Support\Collection::offsetExists($key) should either be c
  ompatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress
   the notice in /.../laravel-module-tests/vendor/laravel/framework/src/Illuminate/Support/Collection.php:1277

PHP Fatal error:  Uncaught Error: Class "Dotenv\Repository\RepositoryBuilder" not found in /.../laravel-module-tests/vendor/codeception/codeception/src/Codeception/Lib/ParamsLoader.php:119

@TavoNiievez
Copy link
Member

@Naktibalda I wrote it a while ago as well at Codeception/laravel-module-tests#4 (comment)
Laravel 6 is supported until September this year, with considerably less time than June from last year, so you can remove its support and test only with Laravel 8.

@Naktibalda Naktibalda merged commit 55d0d10 into main Apr 20, 2022
@Naktibalda Naktibalda deleted the codecept5 branch May 17, 2022 15:56
@Naktibalda Naktibalda mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

@TavoNiievez TavoNiievez TavoNiievez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Naktibalda @TavoNiievez @Arhell @lapiy