more documentation around creating preview sites #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technovangelist
approved these changes
Jul 13, 2017
README.md
Outdated
| ## Datadog Staff | ||
|
|
||
| * Always branch off of master | ||
| * Create a branch `slack_handle/your_feature` if you would like to create a preview site and run tests |
There was a problem hiding this comment.
i would drop the 'if you would like....' - always create the branch. no ifs
There was a problem hiding this comment.
I don't think the 'if' is meant to operate on 'Create'; it operates on 'you would like to create a preview site"
Probably 'Name' is better: "Name your branch slack_handle/your_feature if you would like to..."
The first item is about creating, and is not optional:
- Create a local branch off of master; never commit directly to master
- Name your branch
slack_handle/your_featureif you would like to create a preview site and run tests
And so on.
There was a problem hiding this comment.
but i think its a good naming strategy and we should encourage it. It seems to be what most do anyway
kmshultz
reviewed
Jul 13, 2017
README.md
Outdated
|
|
||
| * Always branch off of master | ||
| * Create a branch `slack_handle/your_feature` if you would like to create a preview site and run tests | ||
| * Never commit directly to master |
There was a problem hiding this comment.
This seems redundant with the first item. Maybe combine them both: "Always branch off of master; never commit directly to master"
kmshultz
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some more context around how things work. This could all be built out much more, but I have been focusing on not dropping any balls on this migration.