Skip to content

fix: Corrige o PR1481 #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fix: Corrige o PR1481 #1490

merged 1 commit into from
May 22, 2025

Conversation

KokeroO
Copy link
Contributor

@KokeroO KokeroO commented May 22, 2025 •
edited by sourcery-ai bot
Loading

Problema

O #1481 trouxe um erro de query na inversão da condicional.

      if (conversationId) {
        query = 'SELECT source_id FROM messages WHERE source_id = ANY($1)';
      }

      if (!conversationId) {
        query = 'SELECT source_id FROM messages WHERE source_id = ANY($1) AND conversation_id = $2';
      }

Deve ser:

      if (conversationId) {
        query = 'SELECT source_id FROM messages WHERE source_id = ANY($1) AND conversation_id = $2';
      }

      if (!conversationId) {
        query = 'SELECT source_id FROM messages WHERE source_id = ANY($1)';
      }

Summary by Sourcery

Bug Fixes:

  • Swap SQL query branches so the conversation_id clause is included when conversationId exists and omitted otherwise

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented May 22, 2025 •
edited
Loading

Reviewer's Guide

Corrects the conditional logic in the Chatwoot import helper so that when a conversationId is provided, the query includes an AND conversation_id clause, and when it isn’t, only the source_id filter is applied.

Sequence diagram for Chatwoot import without conversationId (Corrected)

sequenceDiagram
    participant CI as ChatwootImport
    participant DB as PostgreSQL Database
    CI->>DB: Execute query: SELECT source_id FROM messages WHERE source_id = ANY($1)
    DB-->>CI: Return filtered messages
Loading

File-Level Changes

Change Details Files
Fix conditional logic for message source_id query
  • Include conversation_id filter when conversationId is truthy
  • Remove conversation_id filter when conversationId is falsy
 src/api/integrations/chatbot/chatwoot/utils/chatwoot-import-helper.ts

Possibly linked issues

  • QR NÃO É GERADO #1526: PR fixes the source_id query in Chatwoot import to apply conversation filter, addressing the issue.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@DavidsonGomes DavidsonGomes changed the base branch from main to develop May 22, 2025 20:08
@DavidsonGomes DavidsonGomes merged commit 0239638 into EvolutionAPI:develop May 22, 2025
1 check failed
@KokeroO KokeroO mentioned this pull request May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KokeroO @DavidsonGomes