Skip to content

Aggregated Feed: Paginated Activities #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

sachaarbonel
Copy link
Member

No description provided.

@sachaarbonel sachaarbonel changed the title PaginatedActivities model wip Aggregated Feed: Paginated Activities Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #219 (b5f7f85) into master (90789df) will decrease coverage by 0.96%.
The diff coverage is 35.57%.

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   76.94%   75.98%   -0.97%     
==========================================
  Files         139      143       +4     
  Lines        4646     4738      +92     
==========================================
+ Hits         3575     3600      +25     
- Misses       1071     1138      +67     
Impacted Files Coverage Δ
packages/faye_dart/lib/src/subscription.dart 76.92% <ø> (ø)
...es/stream_feed/lib/src/client/aggregated_feed.dart 73.33% <0.00%> (-20.96%) ⬇️
...ream_feed/lib/src/client/image_storage_client.dart 91.30% <ø> (ø)
...s/stream_feed/lib/src/client/reactions_client.dart 91.17% <ø> (ø)
...stream_feed/lib/src/client/stream_feed_client.dart 100.00% <ø> (ø)
...m_feed/lib/src/client/stream_feed_client_impl.dart 86.62% <ø> (ø)
...ckages/stream_feed/lib/src/core/api/batch_api.dart 1.49% <ø> (ø)
...es/stream_feed/lib/src/core/api/reactions_api.dart 96.82% <ø> (ø)
...eam_feed/lib/src/core/http/stream_http_client.dart 71.21% <ø> (ø)
...ckages/stream_feed/lib/src/core/models/filter.dart 76.47% <0.00%> (-10.20%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8b237...b5f7f85. Read the comment docs.

@sachaarbonel sachaarbonel changed the base branch from master to core-add-pagination April 25, 2022 16:07
@sachaarbonel sachaarbonel marked this pull request as ready for review April 25, 2022 16:07
@sachaarbonel sachaarbonel merged commit 4b5a9c8 into core-add-pagination Apr 25, 2022
@sachaarbonel sachaarbonel deleted the paginate-aggregate-feeds branch April 25, 2022 16:08
sachaarbonel added a commit that referenced this pull request May 27, 2022
* fix: use data not used on setUser

* feat: add pagination management to core feed bloc

* feat: update and expand core example

* docs: update CHANGELOG

* fix ci

* ui kit: bump depedency

* bump dev dependencies

* github action build workflow: channel stable

* ui kit: fix full screen media test

* ui kit: fix debug fill properties test

* ui kit: fix FlatActivityListPage test

* fix test: !timersPending exception
A Timer is still pending even after the widget tree was disposed.

* fix flat feed core test

* bloc: queryPaginatedReactions wip

* loadMoreReactions wip

* test bloc.queryPaginatedReactions

* Aggregated Feed: Paginated Activities (#219)

* aggregated feed builder wip

* loadMoreGroupedActivities

* fix analyzer

* internal annotation

* update todo

* make NextParams const

* apply reviews

* test queryPaginatedGroupedActivities wip

* clean up a bit + aggregated feed test passing

* format

* onAddActivityGroup + getEnrichedActivityDetail
+onRemoveActivityGroup

* test AggregatedFeedCore

* test getEnrichedActivity

* format

* test onAddActivityGroup

* feat: add refresh to feed bloc and other fixes

* feat: add flags to paginated results

* fix: nested child reactions now reactive

* fix fileExt extension for .mov

* fix linter issues

* time parameter in onAddActivity

* ImagePreview: fix typo in error message

* make GenericFeedBloc immutable

* make GenericFeedBloc immutable

* fix: add missing pubspec file

* test: fix missing flags argument

* chore: fix linter warnings

* chore: avoid print

* test: update

* chore: fix lints

* chore: remove late keyword

* remove activity and lookupAttr

* feat: add core build context extensions

* docs: expand core example

* format

* chore: update example

* format

* fix bloc test

* format

* update llc and faye changelogs

* faye: version bump

* update pubspec and tweak changelog

* llc: tweak changelog + bump pubspec version

* workflow: reduce min_coverage constraint

* tweak changelog

* update version header in llc

* version bump

Co-authored-by: Sacha Arbonel <sacha.arbonel@hotmail.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant