Skip to content

core: add pagination and update example #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 67 commits into from
May 27, 2022
Merged

core: add pagination and update example #222

merged 67 commits into from
May 27, 2022

Conversation

HayesGordon
Copy link
Contributor

This is a draft pull request.

There are a few things to consider:

  • Better ways to handle/store the pagination within the bloc
  • Deprecating queryEnrichedActivities in favor of queryPaginatedEnrichedActivities
  • There are a few places that will benefit from logs, marked as TODO
  • Expanding on the tests

We will also need similar logic for ReactionListCore and wherever else pagination is needed.

NOTE: There is a bug in the childReactions, where ownChildren is not being retrieved/stored on a reaction. This is a separate issue outside of this pull request, however, the updated example illustrates the problem.

@codecov
Copy link

codecov bot commented Apr 22, 2022 •
edited
Loading

Codecov Report

Merging #222 (2136915) into master (90789df) will decrease coverage by 2.64%.
The diff coverage is 57.50%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   76.94%   74.30%   -2.65%     
==========================================
  Files         139      145       +6     
  Lines        4646     5024     +378     
==========================================
+ Hits         3575     3733     +158     
- Misses       1071     1291     +220
Impacted Files Coverage Δ
packages/faye_dart/lib/src/client.dart 0.47% <0.00%> (ø)
packages/faye_dart/lib/src/error.dart 100.00% <ø> (ø)
...m_feed/lib/src/client/batch_operations_client.dart 3.57% <ø> (ø)
packages/stream_feed/lib/src/client/feed.dart 77.50% <ø> (ø)
...ream_feed/lib/src/client/image_storage_client.dart 91.30% <ø> (ø)
...am_feed/lib/src/client/personalization_client.dart 0.00% <ø> (ø)
...s/stream_feed/lib/src/client/reactions_client.dart 91.17% <ø> (ø)
...stream_feed/lib/src/client/stream_feed_client.dart 100.00% <ø> (ø)
...ckages/stream_feed/lib/src/core/api/batch_api.dart 1.49% <ø> (ø)
...es/stream_feed/lib/src/core/api/reactions_api.dart 95.31% <0.00%> (-1.52%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8b237...2136915. Read the comment docs.

@sachaarbonel sachaarbonel mentioned this pull request Apr 25, 2022
Closed
HayesGordon
HayesGordon commented Apr 26, 2022
View reviewed changes
HayesGordon
HayesGordon commented Apr 26, 2022
View reviewed changes
HayesGordon
HayesGordon commented Apr 26, 2022
View reviewed changes
HayesGordon
HayesGordon commented Apr 26, 2022
View reviewed changes
@rlee1990
Copy link

Any update on this?

@rlee1990
Copy link

@HayesGordon @sachaarbonel Any update on this? I really need this.

@sachaarbonel sachaarbonel marked this pull request as ready for review May 27, 2022 16:20
@sachaarbonel sachaarbonel merged commit 4c4a51f into master May 27, 2022
@sachaarbonel sachaarbonel deleted the core-add-pagination branch May 27, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HayesGordon @rlee1990 @sachaarbonel