Skip to content

chore(functions): fix flaky tests + update dir property #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 26, 2021
Merged

chore(functions): fix flaky tests + update dir property #5305

merged 4 commits into from
May 26, 2021

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 25, 2021

This should fix #5250 and #5257

(I wasn't able to reproduce them locally, but this makes the tests themselves more fault-tolerant.)

@ace-n ace-n requested review from averikitsch and a team May 25, 2021 04:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2021
@ace-n ace-n linked an issue May 25, 2021 that may be closed by this pull request
functions.ExampleIT: helloPubSub_shouldRunWithFunctionsFramework failed #5257
Closed
@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels May 25, 2021
@ace-n ace-n mentioned this pull request May 25, 2021
Merged
1 task
lesv
lesv suggested changes May 25, 2021
View reviewed changes
functions/helloworld/hello-gcs/src/test/java/functions/ExampleIT.java
Comment on lines +100 to +102
} catch (IOException e) {
return true;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably say a bit more here. Why is this the right thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See retryOnResultPredicate on this page.

Happy to link to that in a comment, if that would help?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL?

@lesv
Copy link
Contributor

lesv commented May 25, 2021

Lint

#
# functions/helloworld/hello-gcs
#

[ERROR] src/test/java/functions/ExampleIT.java:[96,24] (naming) LambdaParameterName: Lambda parameter name '__' must match pattern '^[a-z]([a-z0-9][a-zA-Z0-9]*)?$'.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default-cli) on project functions-hello-gcs: You have 1 Checkstyle violation. -> [Help 1]


#
# functions/helloworld/hello-pubsub
#

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default-cli) on project functions-hello-pub-sub: Execution default-cli of goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check failed: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-checkstyle-plugin:jar:3.1.2 -> org.apache.maven:maven-core:jar:3.0 -> org.apache.maven:maven-aether-provider:jar:3.0 -> org.sonatype.aether:aether-api:jar:1.7: Failed to read artifact descriptor for org.sonatype.aether:aether-api:jar:1.7: Could not transfer artifact org.sonatype.aether:aether-parent:pom:1.7 from/to central (https://repo.maven.apache.org/maven2): /root/.m2/repository/org/sonatype/aether/aether-parent/1.7/aether-parent-1.7.pom.part (No such file or directory) -> [Help 1]

@ace-n
Copy link
Contributor Author

ace-n commented May 26, 2021

@lesv thanks - see this checkstyle change.

@ace-n ace-n merged commit 65367c7 into master May 26, 2021
@ace-n ace-n deleted the fix-flaky branch May 26, 2021 20:20
@ace-n ace-n mentioned this pull request Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch

Assignees

@averikitsch averikitsch

Labels
api: cloudfunctions Issues related to the Cloud Run functions API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

functions.ExampleIT: helloPubSub_shouldRunWithFunctionsFramework failed functions.ExampleIT: helloHttp_shouldRunWithFunctionsFramework failed
3 participants
@ace-n @lesv @averikitsch