chore(functions): increase retry counts for flaky tests #5345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2021 21:24
lesv
approved these changes
Jun 2, 2021
averikitsch
reviewed
Jun 7, 2021
| @@ -145,6 +145,7 @@ | |||
| <version>0.9.7</version> | |||
| <configuration> | |||
| <functionTarget>functions.HelloPubSub</functionTarget> | |||
| <port>8083</port> | |||
There was a problem hiding this comment.
Should we be hard coding this value, even if it's for the tests? Does this change how a user will deploy this sample?
There was a problem hiding this comment.
It shouldn't change deployment or test-running.
(cl/377974756 is the only thing changed by this PR.)
The alternative would be to use some port-provisioning/leasing system, but that seems too complicated IMHO.
There was a problem hiding this comment.
I see, can you add a comment for the user on why it's there
There was a problem hiding this comment.
I added one to the sample itself (already).
Bearing that in mind, did you also want me to add something to pom.xml?
averikitsch
reviewed
Jun 7, 2021
functions/helloworld/hello-pubsub/src/test/java/functions/ExampleIT.java
Outdated
Show resolved
Hide resolved
Merged
1 task
Co-authored-by: Averi Kitsch <akitsch@google.com>
This was referenced Jun 7, 2021
averikitsch
approved these changes
Jun 7, 2021
| @@ -145,6 +145,7 @@ | |||
| <version>0.9.7</version> | |||
| <configuration> | |||
| <functionTarget>functions.HelloPubSub</functionTarget> | |||
| <port>8083</port> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5250 and #5305