Skip to content

chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2021
Merged

chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 #5379

merged 1 commit into from
Jun 7, 2021

Conversation

renovate-bot
Copy link
Contributor

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud.samples:shared-configuration 1.0.22 -> 1.0.23 age adoption passing confidence

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from gcseh and a team as code owners June 4, 2021 22:22
@renovate-bot renovate-bot requested a review from a team June 4, 2021 22:22
@forking-renovate forking-renovate bot added the automerge Merge the pull request once unit tests and other checks pass. label Jun 4, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 5, 2021
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud.samples-shared-configuration-1.x branch from c6d650e to cf23c3f Compare June 6, 2021 18:30
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2021
@lesv
Copy link
Contributor

lesv commented Jun 7, 2021

Lint

#
# iap
#

[ERROR] src/main/java/com/example/iap/BuildIapRequest.java:[18,1] (whitespace) EmptyLineSeparator: '//' should be separated from previous line.
[ERROR] src/main/java/com/example/iap/VerifyIapRequestHeader.java:[18,1] (whitespace) EmptyLineSeparator: '//' should be separated from previous line.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default-cli) on project iap-samples: You have 2 Checkstyle violations. -> [Help 1]

Java 8

com.amazonaws.services.s3.model.AmazonS3Exception: The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method. (Service: Amazon S3; Status Code: 403; Error Code: SignatureDoesNotMatch; Request ID: null; S3 Extended Request ID: null; Proxy: null), S3 Extended Request ID: null

Java 11

Test
ExampleIT(sponge_log).helloPubSub_shouldRunWithFunctionsFramework

Run time 0:00:04.808
Failed: expected to contain: Hello 80123f72-c50b-4b4a-9d96-585928c41fbd! but was :
com.google.common.truth.AssertionErrorWithFacts:
expected to contain: Hello 80123f72-c50b-4b4a-9d96-585928c41fbd!
but was            :
	at functions.hello.pub.sub@1.0.23/functions.ExampleIT.helloPubSub_shouldRunWithFunctionsFramework(ExampleIT.java:118)

@lesv
Copy link
Contributor

lesv commented Jun 7, 2021

@lesv lesv merged commit 5f4ba12 into GoogleCloudPlatform:master Jun 7, 2021
This was referenced Jun 7, 2021
Closed
Closed
@renovate-bot renovate-bot deleted the renovate/com.google.cloud.samples-shared-configuration-1.x branch June 7, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaball35 eaball35 eaball35 approved these changes

@gcseh gcseh Awaiting requested review from gcseh

Assignees

@eaball35 eaball35

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renovate-bot @lesv @eaball35 @kokoro-team