-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore: adding code for bulk instances insert in cloud-client #6131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Added linted code.
compute/cloud-client/src/main/java/compute/CreateBulkInstances.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/CreateBulkInstances.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/CreateBulkInstances.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/CreateBulkInstances.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/CreateBulkInstances.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/CreateBulkInstances.java
Outdated
Show resolved
Hide resolved
Resolved the issues as suggested
@SriharshaM It looks like you have some failing tests for Java 11. Can you fix them? Please let me know if you need help debugging them.
|
@shubha-rajan I am not able to replicate the bulk instances error although that seems to have to do with my code. I am not sure of the firewall one as that seems to have been some hard coding which does not seem to be from my code. Can you please clarify on this. TIA! |
Going through the build logs, I saw that the API you are trying to hit has a malformed URL. The firewall exception occurs during the cleanup() phase. Let @shubha-rajan or I know if we could help! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@SriharshaM @Sita04 @shubha-rajan PTAL or close |
Hi Averi,
Please close it for now. Will open a new PR if I want to push the code.
Thanks!
Thanks and Regards,
Harsha.
…On Tue, 28 Jun 2022, 01:47 Averi Kitsch, ***@***.***> wrote:
@SriharshaM <https://github.com/SriharshaM> @Sita04
<https://github.com/Sita04> @shubha-rajan
<https://github.com/shubha-rajan> PTAL or close
—
Reply to this email directly, view it on GitHub
<#6131 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPOPFG5UIPCT44SGTUM2P3VRID5RANCNFSM5FMEO7IA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Fixes #issue
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only