Skip to content

docs(compute-samples): added method to check for GCE Enforcer based firewall rule deletion #6308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2021
Merged

docs(compute-samples): added method to check for GCE Enforcer based firewall rule deletion #6308

merged 2 commits into from
Oct 27, 2021

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Oct 26, 2021 •
edited
Loading

Checks to see if the firewall rule is auto-deleted by GCE Enforcer.

@m-strzelczyk PTAL

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2021
@Sita04 Sita04 changed the title docs(compute-samples): included method to check if firewall rule is a… docs(compute-samples): added check for GCE Enforcer based firewall rule deletion Oct 26, 2021
@Sita04 Sita04 changed the title docs(compute-samples): added check for GCE Enforcer based firewall rule deletion docs(compute-samples): added method to check for GCE Enforcer based firewall rule deletion Oct 26, 2021
@Sita04 Sita04 requested a review from lesv October 26, 2021 19:51
@Sita04
Copy link
Contributor Author

Sita04 commented Oct 26, 2021

I've done workarounds to two testcases inorder to avoid being executed post the GCE Enforcer.
Please lmk if there's a better way to do get around the enforcer rules.

@Sita04 Sita04 requested review from m-strzelczyk and removed request for m-strzelczyk October 26, 2021 19:56
@Sita04 Sita04 merged commit e8a069c into main Oct 27, 2021
@Sita04 Sita04 deleted the firewall-patch-gce-enforcer branch October 27, 2021 04:50
@Sita04 Sita04 mentioned this pull request Oct 27, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@averikitsch averikitsch

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sita04 @lesv @averikitsch