Outdated bash operator import on Composer 2 Docs #11433 #11440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update samples for google-cloud-speech to improve usability
…bility Handling Issue GoogleCloudPlatform#11248
…mples Handling Issue GoogleCloudPlatform#11248 - Update samples for google-cloud-speech to improve usability
Outdated bash operator import on Composer 2 Docs GoogleCloudPlatform#11433
Outdated bash operator import on Composer 2 Docs GoogleCloudPlatform#11433
holtskinner
previously approved these changes
Apr 12, 2024
georgefjtaylorwarp
suggested changes
Apr 16, 2024
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| from airflow import models | |||
|
|
|||
| from airflow.operators.bash_operator import BashOperator | |||
| from airflow.operators.bash import BashOperator | |||
| from airflow.operators.python_operator import PythonOperator | |||
There was a problem hiding this comment.
from airflow.operators.python import PythonOperator
Comment on lines
21
to
23
| from airflow.providers.google.cloud.operators.gcs import GCSCreateBucketOperator | ||
| from airflow.providers.google.cloud.operators.gcs import GCSDeleteBucketOperator | ||
| from airflow.providers.google.cloud.operators.gcs import GCSListObjectsOperator |
There was a problem hiding this comment.
Not sure on styling specifics, is more concise for:
from airflow.providers.google.cloud.operators.gcs import GCSCreateBucketOperator, GCSDeleteBucketOperator, GCSListObjectsOperator?
georgefjtaylorwarp
approved these changes
Apr 16, 2024
leahecole
requested changes
Apr 18, 2024
There was a problem hiding this comment.
I left some comments - there are places where the BashOperator should not be modified. Additionally, please revert the changes in the endpoint and speech directories and submit them as separate PRs with linked issues. Additionally, I changed it to be a Draft PR while lint and tests are not passing. Feel free to change it back to "ready to review" once they are passing!
composer/blog/gcp-tech-blog/unit-test-dags-cloud-build/dags/example_dag.py
Outdated
Show resolved
Hide resolved
reverting Airflow 1 changes where relevant
leahecole
reviewed
Apr 23, 2024
leahecole
reviewed
Apr 23, 2024
Removing changes made in GoogleCloudPlatform#11332
leahecole
reviewed
Apr 23, 2024
leahecole
reviewed
Apr 23, 2024
leahecole
reviewed
Apr 23, 2024
leahecole
reviewed
Apr 23, 2024
leahecole
reviewed
Apr 23, 2024
leahecole
reviewed
Apr 23, 2024
leahecole
reviewed
Apr 23, 2024
leahecole
reviewed
Apr 23, 2024
revert speech code changes
leahecole
reviewed
Apr 23, 2024
leahecole
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11433
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)