Skip to content

chore(deps): update dependency cloudevents to v1.11.0 #12093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 1, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cloudevents ==1.10.1 -> ==1.11.0 age adoption passing confidence

Release Notes

cloudevents/sdk-python (cloudevents)

v1.11.0

Compare Source

Fixed
  • Pydantic v2 examples keyword usage and improved typings handling ([#​235])
  • Kafka to_binary check for invalid content-type attribute ([#​232])
Changed
  • Dropped Python3.7 from CI while its EOL. ([#​236])

Configuration

📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team as code owners August 1, 2024 03:32
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 1, 2024
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudfunctions Issues related to the Cloud Run functions API. api: eventarc Issues related to the Eventarc API. labels Aug 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 1, 2024
@davidcavazos
Copy link
Contributor

functions/v2/ocr/main_test.py is failing on Python 3.12 with error ModuleNotFoundError: No module named 'pkg_resources'. Seems like a Python 3.12 incompatibility, we might need to disable 3.12 for this one.

@jrmfg
Copy link

jrmfg commented Aug 19, 2024

functions/v2/ocr/main_test.py is failing on Python 3.12 with error ModuleNotFoundError: No module named 'pkg_resources'. Seems like a Python 3.12 incompatibility, we might need to disable 3.12 for this one.

might make sense to add a dependency on setuptools in the ocr v2/ sample, as long as it's still doing the import there. otherwise things will stay broken for 3.12 and 3.13 and onwards. looks like python/cpython#95299 that bites us.

@glasnt
Copy link
Contributor

glasnt commented Sep 4, 2024

cloudevents itself doesn't yet support 3.12 (per setup.py listing, and also it's explicit import of pkg_resources, but that's not where the error is coming from.

Traceback:
/usr/local/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
main_test.py:23: in 
    import main
main.py:26: in 
    from google.cloud import translate_v2 as translate
.nox/py-3-12/lib/python3.12/site-packages/google/cloud/translate_v2/__init__.py:18: in 
    from pkg_resources import get_distribution
E   ModuleNotFoundError: No module named 'pkg_resources'

This is from an older version of google-cloud-translate, as 3.12 support was added in https://github.com/googleapis/google-cloud-python/releases/tag/google-cloud-translate-v3.13.0

Not sure why the google-cloud-translate deps are so out of date, but updating that may help this one (but cloudevents still needs an update)

@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@renovate-bot renovate-bot force-pushed the renovate/cloudevents-1.x branch from 647527a to 02a8eb0 Compare September 4, 2024 22:40
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@renovate-bot renovate-bot force-pushed the renovate/cloudevents-1.x branch from 02a8eb0 to a82aa4b Compare September 4, 2024 22:44
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@glasnt
Copy link
Contributor

glasnt commented Sep 4, 2024

@davidcavazos with the update of google-cloud-translate this PR now passes CI

@glasnt glasnt assigned davidcavazos and unassigned iennae Sep 4, 2024
@davidcavazos davidcavazos merged commit 46e649e into GoogleCloudPlatform:main Sep 5, 2024
11 checks passed
@renovate-bot renovate-bot deleted the renovate/cloudevents-1.x branch September 5, 2024 19:23
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. api: eventarc Issues related to the Eventarc API. owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants