Skip to content

fix: remove arbitrary equality comparisons (not supported by renovate) #12561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 4, 2024
Merged

fix: remove arbitrary equality comparisons (not supported by renovate) #12561

merged 5 commits into from
Sep 4, 2024

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Sep 4, 2024

Should help resolves errors while running renovate

Currently, #4745 reports "Unexpected range error"

Unexpected range error

Running npx renovate --platform local gives more details:

 WARN: Unexpected range error (repository=local)
       "currentValue": "===2.0.1",
       "err": {
         "message": "PEP440 arbitrary equality (===) not supported",
         "stack": "TypeError: PEP440 arbitrary equality (===) not supported [...]"

Checking all requirements*.txt files, I've removed all === references (markupsafe and mock)

While this is valid in PEP440, per the message it's not supported in Renovate.

This may help unblock a number of pending dependency updates (e.g. #12093 (comment))

@glasnt glasnt requested review from a team as code owners September 4, 2024 04:34
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Sep 4, 2024
@glasnt
Copy link
Contributor Author

glasnt commented Sep 4, 2024

A number of samples in this set have linting errors, and Python 3+ errors

../appengine_helper.py:24: in 
    import six
E   ModuleNotFoundError: No module named 'six'

(Numerous import order errors)

@iennae iennae merged commit d4bccd2 into main Sep 4, 2024
15 checks passed
@iennae iennae deleted the artitrary branch September 4, 2024 21:01
@glasnt glasnt mentioned this pull request Sep 13, 2024
Closed
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
@glasnt @riathakkar
fix: remove arbitrary equality comparisons (not supported by renovate) (
21055c3 
GoogleCloudPlatform#12561)

* fix: update syntax for markupsafe deps

* update syntax for mock deps

* provide python3 versions of pytest, mock

* add six to samples that require it

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

@m-strzelczyk m-strzelczyk

Labels
api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glasnt @m-strzelczyk @iennae