-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Add a new sample service for Endpoints Frameworks for Python #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new sample service for Endpoints Frameworks for Python #1325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, just two nits.
basic_scaling: | ||
max_instances: 2 | ||
|
||
#[START_EXCLUDE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are in the app.yaml in appengine/standard/endpoints-frameworks-v2/echo; do you know why they're there? I just mimicked that.
@@ -0,0 +1,4 @@ | |||
from google.appengine.ext import vendor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a license header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is identical to (and was copied from) the equivalent file in appengine/standard/endpoints-frameworks-v2/echo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs a license header. :)
The IATA sample service provides examples of CRUD operations, managing a list of airports and their corresponding IATA codes. This service will be used in documentation for the Endpoints Frameworks.
Done. |
The IATA sample service provides examples of CRUD operations, managing
a list of airports and their corresponding IATA codes. This service
will be used in documentation for the Endpoints Frameworks.