Skip to content

Add a new sample service for Endpoints Frameworks for Python #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Add a new sample service for Endpoints Frameworks for Python #1325

merged 1 commit into from
Feb 22, 2018

Conversation

inklesspen
Copy link
Contributor

The IATA sample service provides examples of CRUD operations, managing
a list of airports and their corresponding IATA codes. This service
will be used in documentation for the Endpoints Frameworks.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2018
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just two nits.

basic_scaling:
max_instances: 2

#[START_EXCLUDE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are in the app.yaml in appengine/standard/endpoints-frameworks-v2/echo; do you know why they're there? I just mimicked that.

@@ -0,0 +1,4 @@
from google.appengine.ext import vendor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a license header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is identical to (and was copied from) the equivalent file in appengine/standard/endpoints-frameworks-v2/echo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs a license header. :)

The IATA sample service provides examples of CRUD operations, managing
a list of airports and their corresponding IATA codes. This service
will be used in documentation for the Endpoints Frameworks.
@inklesspen
Copy link
Contributor Author

Done.

@theacodes theacodes merged commit 1e80ba6 into GoogleCloudPlatform:master Feb 22, 2018
@inklesspen inklesspen deleted the iata-sample-service branch February 22, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants