Skip to content

Decode base64.b64decode output as string for Python 3 compatibility. #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2019
Merged

Decode base64.b64decode output as string for Python 3 compatibility. #1910

merged 4 commits into from
Jan 25, 2019

Conversation

wwlian
Copy link
Contributor

@wwlian wwlian commented Dec 6, 2018

Closes #1895

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2018
engelke
engelke approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke mentioned this pull request Dec 6, 2018
Closed
@jmcarp
Copy link
Contributor

jmcarp commented Dec 8, 2018 •
edited
Loading

It looks like we're decoding json here, so do we need to use ast.literal_eval? I switched to json.loads in #1919, and it's working fine for me on python 2 and 3.

@engelke
Copy link
Contributor

engelke commented Jan 25, 2019

Kokoro tests are not running automatically, and are not passing, for reasons unrelated to this PR.

@engelke engelke merged commit b393619 into GoogleCloudPlatform:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wwlian @jmcarp @engelke @googlebot