-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Fix bigtable tests #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bigtable tests #2740
Conversation
I added a "BIGTABLE_INSTANCE" variable to the encrypted file with environment variables. Not sure if it didn't get picked up or wasn't done correctly. I changed it because "BIGTABLE_CLUSTER" is incorrect since it's talking about the instance, and it's inconsistent with other languages, which makes maintaining this code more difficult |
reverted, but made sure binary file was updated with that change, and that seems to have fixed things |
OH WAIT it doesn't run bigtable tests, only testing. hmm one sec ill trigger it |
Alright @billyjacobson - I got your KeyError fixed but we're exceeding quota. Is there anything we can do to refactor for that, or should we just request more quota? Also, I'll remove those placeholder comments and fix the lint before we merge :) |
…amples into fix_bigtable_tests
…ython-docs-samples into fix_bigtable_tests
@kurtisvg and @billyjacobson - when you take a look at the review, if you look at the failed build on the previous commit, you can see that all of the affected bigtable tests passed - on this run of the build, it just ran against |
Ignore til it's not a holiday! I'm doing some work today in anticipation for an upcoming vacation.
@billyjacobson, I just updated it to call the environment var in the testing