Skip to content

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole commented Jan 20, 2020

Ignore til it's not a holiday! I'm doing some work today in anticipation for an upcoming vacation.

@billyjacobson, I just updated it to call the environment var in the testing

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 20, 2020
@leahecole leahecole marked this pull request as ready for review January 20, 2020 18:00
@leahecole leahecole requested review from billyjacobson and a team as code owners January 20, 2020 18:00
@leahecole leahecole changed the title Test commit to see if this resolves bigtable test Fix bigtable tests Jan 20, 2020
kurtisvg
kurtisvg previously approved these changes Jan 21, 2020
@billyjacobson
Copy link
Member

I added a "BIGTABLE_INSTANCE" variable to the encrypted file with environment variables. Not sure if it didn't get picked up or wasn't done correctly.

I changed it because "BIGTABLE_CLUSTER" is incorrect since it's talking about the instance, and it's inconsistent with other languages, which makes maintaining this code more difficult

@leahecole

@leahecole
Copy link
Collaborator Author

reverted, but made sure binary file was updated with that change, and that seems to have fixed things

@leahecole
Copy link
Collaborator Author

OH WAIT it doesn't run bigtable tests, only testing. hmm one sec ill trigger it

@kurtisvg kurtisvg dismissed their stale review January 21, 2020 18:33

outdated

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2020
@leahecole
Copy link
Collaborator Author

Alright @billyjacobson - I got your KeyError fixed but we're exceeding quota. Is there anything we can do to refactor for that, or should we just request more quota?

Also, I'll remove those placeholder comments and fix the lint before we merge :)

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2020
@leahecole
Copy link
Collaborator Author

@kurtisvg and @billyjacobson - when you take a look at the review, if you look at the failed build on the previous commit, you can see that all of the affected bigtable tests passed - on this run of the build, it just ran against testing/ - the only change i made was to remove the comments that triggered the bigtable tests in the first place.

@leahecole leahecole merged commit 10c2e15 into master Jan 21, 2020
@leahecole leahecole deleted the fix_bigtable_tests branch January 21, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants