Skip to content

Adds check for missing gateway ID on gateway commands #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2020
Merged

Adds check for missing gateway ID on gateway commands #2780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1027b08
Adds check for missing gateway ID on gateway commands
gguuss Feb 6, 2020
bd57b9f
Merge branch 'master' into iot-detect-mqtt-nogatewayid
leahecole Feb 6, 2020
2150beb
Adds back flaky directive
gguuss Feb 6, 2020
e5ce81b
Merge branch 'iot-detect-mqtt-nogatewayid' of https://github.com/goog…
gguuss Feb 6, 2020
e23cd2f
Merge branch 'master' into iot-detect-mqtt-nogatewayid
leahecole Feb 6, 2020
4cb0a18
Merge branch 'master' into iot-detect-mqtt-nogatewayid
leahecole Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions iot/api-client/mqtt_example/cloudiot_mqtt_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,11 @@ def mqtt_device_demo(args):
def main():
args = parse_command_line_args()

if args.command.startswith('gateway'):
if (args.gateway_id is None):
print('Error: For gateway commands you must specify a gateway ID')
return

if args.command == 'gateway_listen':
listen_for_messages(
args.service_account_json, args.project_id,
Expand Down
1 change: 1 addition & 0 deletions iot/api-client/mqtt_example/cloudiot_mqtt_example_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ def test_gateway_listen_for_bound_device_configs(test_topic, capsys):
assert 'Received message' in out


@flaky
def test_gateway_send_data_for_device(test_topic, capsys):
gateway_id = device_id_template.format('RS256')
device_id = device_id_template.format('noauthbind')
Expand Down