-
Notifications
You must be signed in to change notification settings - Fork 6.5k
video: use flaky on flaky timeouts #3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@frankyn, I got an error when trying to delete the bucket after the test that the Bucket is not empty.
Any ideas? |
Hi @nnegrey how many objects are the tests working with and do video tests share the bucket with other samples? It's possible to use force delete and still have objects if for example a Temporary Hold or Event-based Hold are set on objects. Force doesn't account for these type of objects. I can't tell from the error which type of failure it is though. |
Each test is supposed to create a temporary bucket and each test should only be creating maybe a handful of output files. The failing test only creates one though.
|
Might've been a weird flaky on the API or storage as I've never seen that error before and this test has been around for a while. Going to merge to fix several bugs. If it comes back up, I'm sure Build Cop will let me know and I'll investigate more from there. |
…on-docs-samples#3385) * video: use flaky on flaky timeouts * Update beta_snippets_test.py * remove api result check * Update beta_snippets_test.py
…on-docs-samples#3385) * video: use flaky on flaky timeouts * Update beta_snippets_test.py * remove api result check * Update beta_snippets_test.py
…on-docs-samples#3385) * video: use flaky on flaky timeouts * Update beta_snippets_test.py * remove api result check * Update beta_snippets_test.py
Fix: #3346
Fix: #3345
Fix: #3344
Fix: #3298
Fix: #2934