Skip to content

video: use flaky on flaky timeouts #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2020
Merged

video: use flaky on flaky timeouts #3385

merged 8 commits into from
Apr 16, 2020

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Apr 13, 2020

Fix: #3346
Fix: #3345
Fix: #3344
Fix: #3298
Fix: #2934

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2020
@nnegrey nnegrey marked this pull request as ready for review April 14, 2020 20:17
@nnegrey nnegrey requested review from sirtorry, telpirion and a team as code owners April 14, 2020 20:17
@nnegrey
Copy link
Contributor Author

nnegrey commented Apr 15, 2020

@frankyn, I got an error when trying to delete the bucket after the test that the Bucket is not empty.
But the code uses:

bucket.delete(force=True)

Any ideas?

@frankyn
Copy link
Contributor

frankyn commented Apr 15, 2020

Hi @nnegrey how many objects are the tests working with and do video tests share the bucket with other samples?

It's possible to use force delete and still have objects if for example a Temporary Hold or Event-based Hold are set on objects. Force doesn't account for these type of objects. I can't tell from the error which type of failure it is though.

@nnegrey
Copy link
Contributor Author

nnegrey commented Apr 16, 2020

Each test is supposed to create a temporary bucket and each test should only be creating maybe a handful of output files. The failing test only creates one though.

# Create a temporary bucket to store annotation output.
    bucket_name = str(uuid.uuid1())
    storage_client = storage.Client()
    bucket = storage_client.create_bucket(bucket_name)
    yield bucket
    # Teardown.
    bucket.delete(force=True)

@nnegrey
Copy link
Contributor Author

nnegrey commented Apr 16, 2020

Might've been a weird flaky on the API or storage as I've never seen that error before and this test has been around for a while. Going to merge to fix several bugs. If it comes back up, I'm sure Build Cop will let me know and I'll investigate more from there.

@nnegrey nnegrey merged commit a0b82aa into master Apr 16, 2020
@nnegrey nnegrey deleted the fix-video-tests branch April 16, 2020 15:19
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
…on-docs-samples#3385)

* video: use flaky on flaky timeouts

* Update beta_snippets_test.py

* remove api result check

* Update beta_snippets_test.py
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
…on-docs-samples#3385)

* video: use flaky on flaky timeouts

* Update beta_snippets_test.py

* remove api result check

* Update beta_snippets_test.py
dizcology pushed a commit that referenced this pull request Sep 11, 2023
* video: use flaky on flaky timeouts

* Update beta_snippets_test.py

* remove api result check

* Update beta_snippets_test.py
leahecole pushed a commit that referenced this pull request Sep 15, 2023
* video: use flaky on flaky timeouts

* Update beta_snippets_test.py

* remove api result check

* Update beta_snippets_test.py
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
…on-docs-samples#3385)

* video: use flaky on flaky timeouts

* Update beta_snippets_test.py

* remove api result check

* Update beta_snippets_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment