Skip to content

[iam] testing: use multiple projects #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented May 16, 2020

part of #3310

@tmatsuo tmatsuo requested a review from a team as a code owner May 16, 2020 05:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 16, 2020

py36 project has Role Administrator

py37 project has Security Admin

My guess is we need Security Admin.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 16, 2020

It seems like you need 3 roles.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 16, 2020

It seems like list_service_accounts errors out with an empty result. Maybe I can just create a dummy service account in each project then it's fine.

@tmatsuo tmatsuo added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels May 16, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@leahecole leahecole removed the automerge Merge the pull request once unit tests and other checks pass. label May 18, 2020
@leahecole
Copy link
Collaborator

removing automerge label until there's a second approval

# build specific Cloud project. You can also use your own string
# to use your own Cloud project.
# 'gcloud_project_env': 'GCLOUD_PROJECT',
'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, this overrides for running locally but doesn't impact CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It affects both.

On Kokoro, it will use one of the python version specific cloud projects (e.g. python-docs-samples-tests-py36).

When you run it locally, you have to set BUILD_SPECIFIC_GCLOUD_PROJECT envvar which is little bit cumbersome, but you'll know this by the error message easily, and you can do:

export BUILD_SPECIFIC_GCLOUD_PROJECT=${GOOGLE_CLOUD_PROJECT}

then it's fine for most cases.

@tmatsuo tmatsuo merged commit e44bacb into GoogleCloudPlatform:master May 18, 2020
@tmatsuo tmatsuo deleted the iam-multi-proj branch May 18, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants