-
Notifications
You must be signed in to change notification settings - Fork 6.5k
[iam] testing: use multiple projects #3772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
py36 project has py37 project has My guess is we need |
It seems like you need 3 roles. |
It seems like |
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
removing automerge label until there's a second approval |
# build specific Cloud project. You can also use your own string | ||
# to use your own Cloud project. | ||
# 'gcloud_project_env': 'GCLOUD_PROJECT', | ||
'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, this overrides for running locally but doesn't impact CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It affects both.
On Kokoro, it will use one of the python version specific cloud projects (e.g. python-docs-samples-tests-py36).
When you run it locally, you have to set BUILD_SPECIFIC_GCLOUD_PROJECT
envvar which is little bit cumbersome, but you'll know this by the error message easily, and you can do:
export BUILD_SPECIFIC_GCLOUD_PROJECT=${GOOGLE_CLOUD_PROJECT}
then it's fine for most cases.
part of #3310