Skip to content

fix(functions): only check if there is a result #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2020
Merged

fix(functions): only check if there is a result #4216

merged 2 commits into from
Jun 30, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jun 30, 2020

fixes #4206
fixes #4207

@tmatsuo tmatsuo requested a review from ace-n June 30, 2020 18:26
@tmatsuo tmatsuo requested a review from a team as a code owner June 30, 2020 18:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2020
@tmatsuo tmatsuo added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 30, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jun 30, 2020

not sure what's going on with the cla check. I'll just merge it.

@tmatsuo tmatsuo merged commit 4a19dfc into GoogleCloudPlatform:master Jun 30, 2020
@tmatsuo tmatsuo deleted the fix-functions branch June 30, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n Awaiting requested review from ace-n

1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
3 participants
@tmatsuo @kurtisvg @googlebot