Skip to content

fix(functions): only check if there is a result #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2020
Merged

fix(functions): only check if there is a result #4216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76841d3
fix(functions): only check if there is a result
Jun 30, 2020
71a5581
Merge branch 'master' into fix-functions
Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions functions/slack/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ def test_verify_web_hook_valid_request(self):
def test_format_slack_message(self):
message = main.format_slack_message('lion', example_response)

assert 'lion' in message['text'].lower()
assert 'lion' in message['attachments'][0]['title'].lower()
# Just make sure there's a result.
assert 'title' in message['attachments'][0]
assert message['attachments'][0]['color'] == '#3367d6'

def test_make_search_request(self):
Expand All @@ -68,9 +68,8 @@ def test_make_search_request(self):
search = entities.search.return_value
search.execute.return_value = example_response
message = main.make_search_request('lion')

assert 'lion' in message['text'].lower()
assert 'lion' in message['attachments'][0]['title'].lower()
# Just make sure there's a result.
assert 'title' in message['attachments'][0]
assert message['attachments'][0]['color'] == '#3367d6'

def test_kg_search(self):
Expand Down